Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31860: Make the font sample in the IDLE font configuration dialog editable. #4106

Merged
merged 5 commits into from
Oct 28, 2017
Merged

bpo-31860: Make the font sample in the IDLE font configuration dialog editable. #4106

merged 5 commits into from
Oct 28, 2017

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 24, 2017 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 type-feature A feature request or enhancement labels Oct 24, 2017
@terryjreedy
Copy link
Member

/about/across/
Patch keeps edit while IDLE remains open by making the text a global and saving the possibly changed text when the dialog is closed. The Frame title and help test are updated. The test patch is a bug fix.

@terryjreedy terryjreedy reopened this Oct 27, 2017
@terryjreedy
Update configdialog.py
873798f 
Edit code by increasing  height to try to force Apveyor to run
terryjreedy
terryjreedy approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass and you do not object, I plan to merge this tomorrow.

@serhiy-storchaka
Copy link
Member Author

LGTM.

@terryjreedy terryjreedy merged commit ed6554c into python:master Oct 28, 2017
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2017
@serhiy-storchaka @miss-islington
bpo-31860: Make the font sample in the IDLE font configuration dialog…
a036e35 
… editable. (pythonGH-4106)

Changes persist while IDLE remains open
(cherry picked from commit ed6554c)
@bedevere-bot
Copy link

GH-4154 is a backport of this pull request to the 3.6 branch.

terryjreedy pushed a commit that referenced this pull request Oct 28, 2017
@miss-islington @terryjreedy
bpo-31860: Make the font sample in the IDLE font configuration dialog…
6a2957d 
… editable. (GH-4106) (#4154)

Changes persist while IDLE remains open
(cherry picked from commit ed6554c)
@serhiy-storchaka serhiy-storchaka deleted the idle-editable-font-sample branch November 11, 2017 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni