Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47061: document module deprecations due to PEP 594 #31984

Merged
merged 5 commits into from
Mar 21, 2022
Merged

bpo-47061: document module deprecations due to PEP 594 #31984

merged 5 commits into from
Mar 21, 2022

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 18, 2022 •
edited by miss-islington
Loading

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only in the superceded subtree.

https://bugs.python.org/issue47061

Automerge-Triggered-By: GH:brettcannon

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Mar 18, 2022
@brettcannon brettcannon requested a review from tiran March 18, 2022 20:33
@brettcannon brettcannon self-assigned this Mar 18, 2022
tiran
tiran reviewed Mar 18, 2022
View reviewed changes
Doc/library/chunk.rst Outdated Show resolved Hide resolved
ngnpope
ngnpope reviewed Mar 19, 2022
View reviewed changes
Doc/library/audioop.rst Outdated Show resolved Hide resolved
@hugovk
Copy link
Member

hugovk commented Mar 19, 2022

Should this also have an entry in "What's New In Python 3.11"?

@brettcannon
Copy link
Member Author

Should this also have an entry in "What's New In Python 3.11"?

I purposefully left one out as I will updating it as I go along and deprecate the modules which I will be doing in separate PRs.

@miss-islington miss-islington merged commit 9ac2de9 into python:main Mar 21, 2022
@miss-islington
Copy link
Contributor

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @brettcannon, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9ac2de922a0f783bd43b8e026e4fb70fd1888572 3.9

@brettcannon brettcannon deleted the pep594-docs branch March 21, 2022 23:16
@bedevere-bot
Copy link

GH-32039 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 21, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2022
@brettcannon @miss-islington
bpo-47061: document module deprecations due to PEP 594 (pythonGH-31984)
1f61ddb 
Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)

Co-authored-by: Brett Cannon <[email protected]>
@brettcannon
Copy link
Member Author

Thanks everyone for the reviews!

miss-islington added a commit that referenced this pull request Mar 22, 2022
@miss-islington
[3.10] bpo-47061: document module deprecations due to PEP 594 (GH-31984…
c353835 
…) (GH-32039)

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)


Co-authored-by: Brett Cannon <[email protected]>

Automerge-Triggered-By: GH:brettcannon
@hugovk
Copy link
Member

hugovk commented Mar 23, 2022

And thanks for the PR!

Is a manual 3.9 backport needed?

@brettcannon
Copy link
Member Author

@hugovk yep, a manual backport for 3.9 is needed. I was planning to tackle it probably this Friday, but if you want to take it on I will not stop you. 😉

hugovk pushed a commit to hugovk/cpython that referenced this pull request Mar 23, 2022
@brettcannon @hugovk
[3.9] bpo-47061: document module deprecations due to PEP 594 (pythonG…
059a8f3 
…H-31984)

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)

Co-authored-by: Brett Cannon <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 23, 2022
@bedevere-bot
Copy link

GH-32082 is a backport of this pull request to the 3.9 branch.

@hugovk
Copy link
Member

hugovk commented Mar 23, 2022

There we go, and the cherry_picker 9ac2de922a0f783bd43b8e026e4fb70fd1888572 3.9 command applied cleanly first time :)

miss-islington pushed a commit that referenced this pull request Mar 23, 2022
@hugovk
[3.9] bpo-47061: document module deprecations due to PEP 594 (GH-31984)…
e513b81 
… (GH-32082)

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)

Co-authored-by: Brett Cannon <[email protected]>

Automerge-Triggered-By: GH:brettcannon
This was referenced Apr 11, 2022
Closed
Closed
@brettcannon brettcannon mentioned this pull request Apr 11, 2022
Closed
@hugovk hugovk mentioned this pull request Apr 26, 2022
Merged
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@hugovk @hello-adam
[3.9] bpo-47061: document module deprecations due to PEP 594 (pythonG…
71691c9 
…H-31984) (pythonGH-32082)

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)

Co-authored-by: Brett Cannon <[email protected]>

Automerge-Triggered-By: GH:brettcannon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

@hugovk hugovk hugovk left review comments

@ngnpope ngnpope ngnpope left review comments

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@brettcannon @hugovk @miss-islington @bedevere-bot @tiran @ngnpope @the-knights-who-say-ni