bpo-31065: Add doc about Popen.poll returns None. #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
gpshead
reviewed
Aug 29, 2017
| @@ -584,7 +584,7 @@ Instances of the :class:`Popen` class have the following methods: | |||
| .. method:: Popen.poll() | |||
|
|
|||
| Check if child process has terminated. Set and return | |||
| :attr:`~Popen.returncode` attribute. | |||
| :attr:`~Popen.returncode` attribute. Otherwise, returns ``None``. | |||
There was a problem hiding this comment.
Elsewhere Popen.returncode is already documented to be None when the process hasn't terminated. But it does not hurt to also make that clear here.
GadgetSteve
pushed a commit
to GadgetSteve/cpython
that referenced
this pull request
Sep 10, 2017
berkerpeksag
pushed a commit
to berkerpeksag/cpython
that referenced
this pull request
Oct 29, 2017
(cherry picked from commit 006617f)
berkerpeksag
added a commit
that referenced
this pull request
Oct 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.python.org/issue31065 for more details.
https://bugs.python.org/issue31065