-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46607: Add DeprecationWarning to LegacyInterpolation #30927
Merged
gpshead
merged 2 commits into
python:main
from
hugovk:issue45173-deprecate-LegacyInterpolation
Apr 5, 2022
Merged
bpo-46607: Add DeprecationWarning to LegacyInterpolation #30927
gpshead
merged 2 commits into
python:main
from
hugovk:issue45173-deprecate-LegacyInterpolation
Apr 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
force-pushed
the
issue45173-deprecate-LegacyInterpolation
branch
from
January 26, 2022 22:00
0541fd9
to
80d4f4a
Compare
This comment has been minimized.
This comment has been minimized.
hugovk
force-pushed
the
issue45173-deprecate-LegacyInterpolation
branch
from
February 2, 2022 07:06
80d4f4a
to
2c616f3
Compare
hugovk
changed the title
bpo-45173: Add DeprecationWarning to LegacyInterpolation
bpo-46607: Add DeprecationWarning to LegacyInterpolation
Feb 2, 2022
This comment was marked as resolved.
This comment was marked as resolved.
hugovk
force-pushed
the
issue45173-deprecate-LegacyInterpolation
branch
from
February 2, 2022 18:45
2c616f3
to
850073b
Compare
… in docs since 3.2
hugovk
force-pushed
the
issue45173-deprecate-LegacyInterpolation
branch
from
February 3, 2022 14:28
850073b
to
2aa86b8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
gvanrossum
approved these changes
Apr 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let’s do this!
gpshead
approved these changes
Apr 5, 2022
@hugovk The PR introduces deprecation warnings in tests that need to be handled :
|
@tirkarthi Thanks, will check it! |
Please see #91480. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegacyInterpolation
has been deprecated in docs since its introduction in Python 3.2:Let's add a
DeprecationWarning
for a couple of releases before removal.https://bugs.python.org/issue46607