Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552) #30552

Merged
merged 9 commits into from
Jan 12, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 11, 2022

Co-authored-by: Ethan Smith [email protected]
Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue40280

@tiran tiran force-pushed the bpo-40280-emscripten-targets branch from a1aab67 to b5b4504 Compare January 11, 2022 23:46
configure Outdated Show resolved Hide resolved
@brettcannon brettcannon self-requested a review January 12, 2022 01:08
configure.ac Show resolved Hide resolved
Copy link
Contributor

@ethanhs ethanhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.

@tiran
Copy link
Member Author

tiran commented Jan 12, 2022

Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.

It does now :)

@tiran tiran marked this pull request as ready for review January 12, 2022 09:01
@tiran tiran changed the title bpo-40280: Add --with-emscripten-target to build for browser or node bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552) Jan 12, 2022
@tiran tiran merged commit 43839ba into python:main Jan 12, 2022
@tiran tiran deleted the bpo-40280-emscripten-targets branch January 12, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants