bpo-45764: improve error message when missing '(' after 'def' #29484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Nov 9, 2021
| ^ | ||
| SyntaxError: expected '(' | ||
|
|
||
| #.. section: Library #.. section: Documentation #.. section: Tests #.. |
There was a problem hiding this comment.
Could you remove the commented part of the news entry? Somehow it got I included in the file?
|
@cfbolz Fantastic! Thanks a lot for the PR! |
pablogsal
approved these changes
Nov 9, 2021
|
@cfbolz: Status check is done, and it's a failure ❌ . |
|
@cfbolz: Status check is done, and it's a success ❌ . |
|
the windows 64 error seems unrelated, I think? |
Yeah, is a known race condition that is very annoying and we still have not found a good way to fix it. @ambv maybe could take a look again as this is everywhere in the CI |
|
@cfbolz: Status check is done, and it's a success ✅ . |
thatbirdguythatuknownot
added a commit
to thatbirdguythatuknownot/cpython
that referenced
this pull request
Nov 9, 2021
thatbirdguythatuknownot
added a commit
to thatbirdguythatuknownot/cpython
that referenced
this pull request
Nov 9, 2021
thatbirdguythatuknownot
added a commit
to thatbirdguythatuknownot/cpython
that referenced
this pull request
Nov 9, 2021
thatbirdguythatuknownot
added a commit
to thatbirdguythatuknownot/cpython
that referenced
this pull request
Nov 9, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
…GH-29484) to achieve this, change the grammar to expect the '(' token after 'def' NAME. Automerge-Triggered-By: GH:pablogsal
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Jan 30, 2022
…GH-29484) to achieve this, change the grammar to expect the '(' token after 'def' NAME. Automerge-Triggered-By: GH:pablogsal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to achieve this, change the grammar to expect the '(' token after 'def' NAME.
https://bugs.python.org/issue45764
Automerge-Triggered-By: GH:pablogsal