bpo-45727: Make the syntax error for missing comma more consistent #29427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks great to me, but I would have expected a new test ;-) |
Yup, somehow I forgot about pushing that 😓 |
pablogsal
added
needs backport to 3.9
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
GH-29647 is a backport of this pull request to the 3.10 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Nov 20, 2021
…tent (pythonGH-29427). (cherry picked from commit 546cefc) Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal
added a commit
that referenced
this pull request
Nov 20, 2021
…tent (GH-29427) (GH-29647) (cherry picked from commit 546cefc) Co-authored-by: Pablo Galindo Salgado <[email protected]>
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45727