Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fixes #2902

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Spelling fixes #2902

merged 1 commit into from
Aug 3, 2017

Conversation

scop
Copy link
Contributor

@scop scop commented Jul 26, 2017

No description provided.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but please withdraw changes in Modules/_ctypes/libffi_msvc/ and Modules/_ctypes/libffi_osx/ directories. They are imported files.

@serhiy-storchaka serhiy-storchaka added skip issue type-feature A feature request or enhancement labels Jul 31, 2017
@scop scop requested a review from brettcannon as a code owner August 3, 2017 05:32
@scop
Copy link
Contributor Author

scop commented Aug 3, 2017

Done.

@serhiy-storchaka
Copy link
Member

For future, please don't squash your commits. This makes reviewing harder. I now need to make full review rather than just checking that only changes to few files were reverted.

@serhiy-storchaka serhiy-storchaka merged commit 49b2734 into python:master Aug 3, 2017
@scop scop deleted the spelling branch August 3, 2017 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants