Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45367: Specialize BINARY_MULTIPLY #28727

Merged
merged 10 commits into from
Oct 14, 2021
Merged

bpo-45367: Specialize BINARY_MULTIPLY #28727

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3c85756
Implement specialized opcodes for BINARY_MULTIPLY
sweeneyde Oct 5, 2021
300a0ca
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 5, 2021
d266912
Resolve merge conflicts
sweeneyde Oct 5, 2021
c64540a
Apply changes from code review
sweeneyde Oct 5, 2021
5a44ecc
Allow float/int mixtures is BINARY_MULTIPLY_FLOAT
sweeneyde Oct 5, 2021
aea424e
Minor cleanups and comments
sweeneyde Oct 5, 2021
37d3716
Revert the float/int mixtures
sweeneyde Oct 7, 2021
903ff9c
typo: sum --> prod
sweeneyde Oct 7, 2021
7aecc97
Merge branch 'main' into multiply
sweeneyde Oct 10, 2021
31c3bb9
Merge main into multiply
sweeneyde Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo: sum --> prod
  • Loading branch information
@sweeneyde
sweeneyde committed Oct 7, 2021
commit 903ff9c7d66186b9364071f4a43faa7afb86f6c7
8 changes: 4 additions & 4 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1955,12 +1955,12 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, InterpreterFrame *frame, int thr
DEOPT_IF(!PyLong_CheckExact(right), BINARY_MULTIPLY);
STAT_INC(BINARY_MULTIPLY, hit);
record_hit_inline(next_instr, oparg);
PyObject *sum = _PyLong_Multiply((PyLongObject *)left, (PyLongObject *)right);
SET_SECOND(sum);
PyObject *prod = _PyLong_Multiply((PyLongObject *)left, (PyLongObject *)right);
SET_SECOND(prod);
Py_DECREF(right);
Py_DECREF(left);
STACK_SHRINK(1);
if (sum == NULL) {
if (prod == NULL) {
goto error;
}
DISPATCH();
Expand All @@ -1980,7 +1980,7 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, InterpreterFrame *frame, int thr
Py_DECREF(right);
Py_DECREF(left);
STACK_SHRINK(1);
if (sum == NULL) {
if (prod == NULL) {
goto error;
}
DISPATCH();
Expand Down