Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45121: Fix issue when Protocol.__init__ raise RecursionError #28206

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

uriyyo
Copy link
Member

@uriyyo uriyyo commented Sep 7, 2021

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions, but the approach seems correct to me. Thanks.

Lib/typing.py Outdated Show resolved Hide resolved
Lib/test/test_typing.py Show resolved Hide resolved
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Yurii.

@Fidget-Spinner Fidget-Spinner added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Sep 8, 2021
@Fidget-Spinner Fidget-Spinner merged commit c11956a into python:main Sep 8, 2021
@miss-islington
Copy link
Contributor

Thanks @uriyyo for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 8, 2021
…ubclass' __init__ (pythonGH-28206)

(cherry picked from commit c11956a)

Co-authored-by: Yurii Karabas <[email protected]>
@miss-islington
Copy link
Contributor

Sorry, @uriyyo and @Fidget-Spinner, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c11956a8bddd75f02ccc7b4da7e4d8123e1f3c5f 3.9

@bedevere-bot
Copy link

GH-28232 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 8, 2021
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Sep 8, 2021
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 8, 2021
@bedevere-bot
Copy link

GH-28233 is a backport of this pull request to the 3.9 branch.

ambv pushed a commit that referenced this pull request Sep 8, 2021
ambv pushed a commit that referenced this pull request Sep 8, 2021
…ubclass' __init__ (GH-28206) (GH-28232)

(cherry picked from commit c11956a)

Co-authored-by: Yurii Karabas <[email protected]>
pablogsal pushed a commit that referenced this pull request Sep 19, 2021
…ubclass' __init__ (GH-28206) (GH-28232)

(cherry picked from commit c11956a)

Co-authored-by: Yurii Karabas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants