bpo-28556: Fix regression that sneaked into recent typing updates #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariatta
approved these changes
Feb 24, 2017
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Feb 24, 2017
…thonGH-270) (cherry picked from commit 365cb5b)
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Feb 24, 2017
…thonGH-270) (cherry picked from commit 365cb5b)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 13, 2021
Stackless now uses an unmodified PyFrameObject structure. The field PyFrameObject.f_executing now stores the information how to evaluate a frame. Additional consequences: - all frame execution functions now take a "PyCFrameObject *" as first argument. - Pickled frames no contain f_executing instead of the name of the execution function.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 14, 2021
Consistent usage of SLP_FRAME_EXECUTING_VALUE
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 14, 2021
Cleanups and minor improvements. Fix _PyEval_EvalFrameDefault
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 14, 2021
Again minor improvements.
akruis
added a commit
to akruis/cpython
that referenced
this pull request
Jun 18, 2021
Stackless now uses an unmodified PyFrameObject structure. The field PyFrameObject.f_executing now stores the information how to evaluate a frame. Additional consequences: - all frame execution functions now take a "PyCFrameObject *" as first argument. - Pickled frames no contain f_executing instead of the name of the execution function.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 18, 2021
Remove unreachable code.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 20, 2021
Fix test_sys.SizeofTest.test_objecttypes for frames. Stackless has now again the same frame size as C-Python.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 20, 2021
Integrate the C-function PyEval_EvalFrameEx_slp into into the C-function slp_eval_frame_value and rename slp_eval_frame_value to PyEval_EvalFrameEx_slp. Adapt the gdb support library and document the change.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 22, 2021
Back to PyEval_EvalFrameEx_slp and slp_eval_frame_value. But without duplicated code. Revert the gdb changes from the previous commit.
akruis
added a commit
to akruis/cpython
that referenced
this pull request
Jun 22, 2021
Eliminate duplicated code in ceval.c to improve maintainability. Update changelog.txt.
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Use GH to signify Github handle of the user instead of "@". "@" usually doesn't give any information about what exactly the handle means since we don't know it is a Github handle from the commit message. Changing the pattern to be `GH:` similar to what we do for Pull Requests with (GH-). Fixes #270 * Handle removing GH:-style Automerge-Triggered-By ...when automerge label is removed by a core-dev. Co-authored-by: Abhilash Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, recent update to typing module introduced a bug: ABC registry of a generic type gets completely wiped out on every subscription. This PR fixes the problem.