Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44297: Fix missing line number in generator expressions #26801

Merged
merged 3 commits into from
Jun 21, 2021
Merged

bpo-44297: Fix missing line number in generator expressions #26801

merged 3 commits into from
Jun 21, 2021

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jun 19, 2021 •
edited by bedevere-bot
Loading

This is an old latent bug, that was fixed up by later compiler passes up to 3.9.

https://bugs.python.org/issue44297

@markshannon markshannon added the needs backport to 3.10 only security fixes label Jun 19, 2021
gvanrossum
gvanrossum approved these changes Jun 19, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gvanrossum
Copy link
Member

There seems to be an unrelated problem with test_logging; its test_race subtest looks flakey.

@markshannon markshannon reopened this Jun 21, 2021
@markshannon markshannon merged commit 82e5c28 into python:main Jun 21, 2021
@miss-islington
Copy link
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @markshannon, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 82e5c28af7049c4f5343c808f172cbe2e145f49b 3.10

markshannon added a commit to markshannon/cpython that referenced this pull request Jun 21, 2021
@markshannon
bpo-44297: Fix missing line number in generator expressions (pythonGH…
b933e81 
…-26801)

* Make sure that line number is set when entering comprehension scope in compiler.

(cherry picked from commit 82e5c28)
@pablogsal
Copy link
Member

#26782 seems to be related, @markshannon can you take a look please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees

@markshannon markshannon

Labels
needs backport to 3.10 only security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markshannon @gvanrossum @miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot