bpo-44117: Remove PyEval_InitThreads() #26070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove PyEval_InitThreads() and PyEval_ThreadsInitialized() functions. The GIL is created by Py_Initialize() since Python 3.7, and so calling explicitly PyEval_InitThreads() was useless since Python 3.7. Deprecated in 3.9, PyEval_InitThreads() did nothing and PyEval_ThreadsInitialized() already returned true.
|
cc @encukou: FYI this PR removes a function from the stable ABI. It was deprecated for 2 Python releases. |
|
Please do not remove functions from the stable ABI. They can be removed from the API (i.e. headers), but should stay in the stable ABI. It is OK if they do nothing. |
|
This PR is stale because it has been open for 30 days with no activity. |
Oh. I didn't notice that. I close my PR and its associated issue. I'm not interested to attempt to only remove it from the API (header files). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PyEval_InitThreads() and PyEval_ThreadsInitialized()
functions. The GIL is created by Py_Initialize() since Python 3.7,
and so calling explicitly PyEval_InitThreads() was useless since
Python 3.7. Deprecated in 3.9, PyEval_InitThreads() did nothing and
PyEval_ThreadsInitialized() already returned true.
https://bugs.python.org/issue44117