Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43826: Fix resource warning due to unclosed objects. #25381

Merged
merged 1 commit into from
Aug 24, 2021
Merged

bpo-43826: Fix resource warning due to unclosed objects. #25381

merged 1 commit into from
Aug 24, 2021

Conversation

tirkarthi
Copy link
Member

@tirkarthi tirkarthi commented Apr 13, 2021 •
edited by bedevere-bot
Loading

@tirkarthi tirkarthi requested a review from gpshead as a code owner April 13, 2021 05:31
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Apr 13, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 3, 2021
serhiy-storchaka
serhiy-storchaka approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I just wrote the same patch. 😉

@tirkarthi tirkarthi closed this Aug 24, 2021
@tirkarthi tirkarthi reopened this Aug 24, 2021
@tirkarthi tirkarthi merged commit 7179930 into python:main Aug 24, 2021
@tirkarthi tirkarthi deleted the bpo43826 branch August 24, 2021 10:43
@tirkarthi
Copy link
Member Author

Thanks @serhiy-storchaka . Given that 3.10 is in release candidate stage and these warnings are for tests I am not adding backport labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees
No one assigned
Labels
skip news stale Stale PR or inactive for long period of time. tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tirkarthi @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot