Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30183: Modify configure to link with the compiler driver under HP-UX #2519

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

datalogics-robb
Copy link
Contributor

@datalogics-robb datalogics-robb commented Jun 30, 2017

When building with the native A cc compiler under HPUX, the linker command 'ld -d' can't accept the compiler commands that tell it to use 64-bit mode. This results in a failed link, either when the library linking ld command fails to recognize +DD64 or when an ABI mismatch is found when $CC is used later.
This PR makes the obvious change to use the compiler drivers to link under hpux when gcc is not the compiler used.

https://bugs.python.org/issue30183

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@datalogics-robb
Copy link
Contributor Author

I signed the CLA and re-submitted the PR, but the knights who until recently said "Ni!" are still asking for a shrubbery. I'm not sure what to do.

@Mariatta
Copy link
Member

Thanks for the PR. The CLA can take one US business day to check, it involves a manual check by a real person :)

@Mariatta
Copy link
Member

You should also create an account in the https://bugs.python.org, and add your GitHub username to that account.

@datalogics-robb
Copy link
Contributor Author

Thanks @Mariatta, I've added my github info to my bugs.python.org account.

@datalogics-robb datalogics-robb changed the title Modify configury to link with the compiler driver under HP-UX bpo-30183: Modify configury to link with the compiler driver under HP-UX Jul 6, 2017
@datalogics-robb
Copy link
Contributor Author

Could someone have a look at merging this? I realize we are a long way from working HPUX support, but the first step is to get something to build.

@merwok merwok changed the title bpo-30183: Modify configury to link with the compiler driver under HP-UX bpo-30183 Modify configury to link with the compiler driver under HP-UX Dec 6, 2017
@ambv ambv changed the title bpo-30183 Modify configury to link with the compiler driver under HP-UX bpo-30183: Modify configure to link with the compiler driver under HP-UX Dec 6, 2017
@ambv
Copy link
Contributor

ambv commented Dec 6, 2017

@merwok Why the colon removal?

@smontanaro
Copy link
Contributor

IANAHPP, but LGTM, Rob.

@merwok
Copy link
Member

merwok commented Dec 6, 2017

I was wondering why the bot didn’t add a link to the ticket in the first message, so I tried removing the colon in case that messed up the parsing.

Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@ambv ambv merged commit 9d25bd1 into python:master Dec 6, 2017
@datalogics-robb datalogics-robb deleted the bpo-30183 branch December 6, 2017 18:15
@Mariatta
Copy link
Member

Mariatta commented Dec 6, 2017

I was wondering why the bot didn’t add a link to the ticket in the first message,

This PR was made before bedevere started adding the bpo url. :)
I personally prefer to close/re-open the PR, that should re-trigger it. Changing the PR title breaks the thread on GMail... only an tiny annoyance for those who subscribe the email notifications :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants