Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40455: Fix gcc10+ warning about writing into a section of offset 0 #24384

Merged
merged 1 commit into from
Jan 30, 2021
Merged

bpo-40455: Fix gcc10+ warning about writing into a section of offset 0 #24384

merged 1 commit into from
Jan 30, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 30, 2021 •
edited by bedevere-bot
Loading

This silences this warnings:

Objects/codeobject.c:414:15: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
414 | *lnotab++ = b;

https://bugs.python.org/issue40455

@pablogsal
bpo-40455: Fix gcc10+ warning about writing into a section of offset 0
6f04e4b 
This silences this warnings:

Objects/codeobject.c:414:15: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
  414 |     *lnotab++ = b;
@corona10 corona10 self-requested a review January 30, 2021 10:04
corona10
corona10 approved these changes Jan 30, 2021
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I locally check this work on my gcc10 machine and the patch works well :)

@corona10 corona10 merged commit 86e322f into python:master Jan 30, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
bpo-40455: Fix gcc10+ warning about writing into a section of offset 0 (
8b1b8e7 
pythonGH-24384)
@vstinner vstinner added the needs backport to 3.9 only security fixes label Apr 13, 2021
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal and @corona10, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 86e322f1412be6c5a6c8fa8e73af68b99c42bb18 3.9

@pablogsal pablogsal deleted the warnings branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees

@corona10 corona10

Labels
needs backport to 3.9 only security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pablogsal @miss-islington @corona10 @vstinner @the-knights-who-say-ni @bedevere-bot