Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42934: use TracebackException's new compact param in unittest.Tes… #24221

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 15, 2021

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you measure the time savings?

@iritkatriel
Copy link
Member Author

No. How would we do that? We can probably create a pathological example where the difference is exponential (a complete binary tree of exceptions).

@iritkatriel
Copy link
Member Author

Ah you mean the time for a buildbot test run?

@gvanrossum
Copy link
Member

It wasn’t a very serious question, let’s not worry about it.

@gvanrossum gvanrossum merged commit ba876c4 into python:master Jan 15, 2021
@iritkatriel iritkatriel deleted the bpo-42934 branch January 15, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants