bpo-30726: Also fix pyexpat.vcxproj #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@segevfiner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @briancurtin and @zooba to be potential reviewers. |
|
ping @Haypo |
segevfiner
added a commit
to segevfiner/cpython
that referenced
this pull request
Jul 4, 2017
(cherry picked from commit 7526cad)
|
GH-2570 is a backport of this pull request to the 3.6 branch. |
segevfiner
added a commit
to segevfiner/cpython
that referenced
this pull request
Jul 4, 2017
(cherry picked from commit 7526cad)
|
GH-2571 is a backport of this pull request to the 3.5 branch. |
|
🐍🍒⛏🤖 Thanks @segevfiner for the PR, and @zooba for merging it 🌮🎉.I'm working now to backport this PR to: 2.7. |
|
Sorry, @segevfiner and @zooba, I could not cleanly backport this to |
|
Backport to 2.7 already done by commit ab3b0ad. I removed the label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Haypo
We have the same issue that you fixed in _elementtree.vcxproj in pyexpat.vcxproj. It doesn't seem like anyone in the CPython core links to this one. But it does produce a static library that is bundled with the CPython distribution. 😖