bpo-42042: Use ids attribute instead of names attribute #22739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
LGTM.
According to https://bugs.python.org/issue42042#msg378815 this change doesn't drop Sphinx 2 support, it only adds Sphinx 3 support.
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
Sorry @corona10, I had trouble checking out the |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 13, 2020
(cherry picked from commit 09490a1) Co-authored-by: Dong-hee Na <[email protected]>
|
GH-23263 is a backport of this pull request to the 3.8 branch. |
bedevere-bot
removed
needs backport to 3.8
needs backport to 3.9
|
GH-23265 is a backport of this pull request to the 3.9 branch. |
corona10
added a commit
to corona10/cpython
that referenced
this pull request
Nov 13, 2020
…GH-22739) (cherry picked from commit 09490a1) Co-authored-by: Dong-hee Na <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 13, 2020
(cherry picked from commit 09490a1) Co-authored-by: Dong-hee Na <[email protected]>
corona10
added a commit
that referenced
this pull request
Nov 13, 2020
…) (GH-23265) (cherry picked from commit 09490a1) Co-authored-by: Dong-hee Na <[email protected]>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue42042