-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-41966: Fix pickling pure datetime.time subclasses #22731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do you mind to add your name in Misc/ACKS
?
@@ -0,0 +1 @@ | |||
Fix pickling pure Python :class:`datetime.time` subclasses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add also "Patch by <yourname>.
" Don't forget sentence-ending points.
Thanks @scaramallion for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
GH-22747 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit c304c9a) Co-authored-by: scaramallion <[email protected]>
(cherry picked from commit c304c9a) Co-authored-by: scaramallion <[email protected]>
GH-22748 is a backport of this pull request to the 3.8 branch. |
Thank you for your contribution Dean! |
…22747) (cherry picked from commit c304c9a) Co-authored-by: scaramallion <[email protected]>
…22748) (cherry picked from commit c304c9a) Co-authored-by: scaramallion <[email protected]>
https://bugs.python.org/issue41966