Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41966: Fix pickling pure datetime.time subclasses #22731

Merged
merged 3 commits into from
Oct 18, 2020
Merged

bpo-41966: Fix pickling pure datetime.time subclasses #22731

merged 3 commits into from
Oct 18, 2020

Conversation

scaramallion
Copy link
Contributor

@scaramallion scaramallion commented Oct 16, 2020

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you mind to add your name in Misc/ACKS?

@@ -0,0 +1 @@
Fix pickling pure Python :class:`datetime.time` subclasses
Copy link
Member

@serhiy-storchaka serhiy-storchaka Oct 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add also "Patch by <yourname>." Don't forget sentence-ending points.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes type-bug An unexpected behavior, bug, or error labels Oct 18, 2020
@serhiy-storchaka serhiy-storchaka merged commit c304c9a into python:master Oct 18, 2020
@miss-islington
Copy link
Contributor

Thanks @scaramallion for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-22747 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2020
@bedevere-bot
Copy link

GH-22748 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Oct 18, 2020
@serhiy-storchaka
Copy link
Member

Thank you for your contribution Dean!

serhiy-storchaka pushed a commit that referenced this pull request Oct 18, 2020
serhiy-storchaka pushed a commit that referenced this pull request Oct 18, 2020
@scaramallion scaramallion deleted the fix-issue-41966 branch October 18, 2020 20:20
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants