bpo-41617: Fix pycore_bitutils.h to support clang 3.0 #22042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__builtin_bswap16() is not available in LLVM clang 3.0.
|
LGTM |
This was referenced Sep 1, 2020
vstinner
added a commit
that referenced
this pull request
Sep 1, 2020
jmroot
reviewed
Sep 20, 2020
| && ((__GNUC__ >= 5) || (__GNUC__ == 4) && (__GNUC_MINOR__ >= 8))) \ | ||
| || (defined(__clang__) \ | ||
| && (__clang_major__ >= 4 \ | ||
| || (__clang_major__ == 3 && __clang_minor__ >= 2)))) |
There was a problem hiding this comment.
Unfortunately this does not work correctly with Apple's clang, which uses a different versioning scheme. Probably the fix in #21949 should be used instead.
|
Unfortunately this does not work correctly with Apple's clang, which uses a
different versioning scheme. Probably the fix in [2]#21949 should be used
instead.
Or write a decent autoconf test ;-)
|
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
__builtin_bswap16() is not available in LLVM clang 3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__builtin_bswap16() is not available in LLVM clang 3.0.
https://bugs.python.org/issue41617