Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40275: Fix failed test cases by using test helpers #21811

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Aug 10, 2020

@shihai1991 shihai1991 requested a review from a team as a code owner August 10, 2020 16:02
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 10, 2020
@shihai1991
Copy link
Member Author

cc @vstinner

@vstinner
Copy link
Member

Sadly, all GitHub actions are skipped. My #21806 PR should fix it.

@vstinner
Copy link
Member

Ah! It's now better with repaired GH Action jobs (no longer skipped)! I'm more confident to merge the PR. I see that macOS is green again, thanks @shihai1991!

@vstinner vstinner merged commit 490c542 into python:master Aug 10, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants