Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41300: IDLE - save files with non-ascii chars #21512

Merged
merged 3 commits into from
Jul 16, 2020
Merged

bpo-41300: IDLE - save files with non-ascii chars #21512

merged 3 commits into from
Jul 16, 2020

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jul 16, 2020 •
edited by bedevere-bot
Loading

Fix regression released in 3.9.0b4 and 3.8.4.

https://bugs.python.org/issue41300

@terryjreedy terryjreedy added type-bug An unexpected behavior, bug, or error needs backport to 3.8 needs backport to 3.9 only security fixes labels Jul 16, 2020
@terryjreedy terryjreedy self-assigned this Jul 16, 2020
@terryjreedy terryjreedy merged commit 38d3864 into python:master Jul 16, 2020
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@terryjreedy terryjreedy deleted the io branch July 16, 2020 22:25
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2020
@terryjreedy @miss-islington
bpo-41300: IDLE - save files with non-ascii chars (pythonGH-21512)
8bd0c2f 
Fix regression released in 3.9.0b4 and 3.8.4.
(cherry picked from commit 38d3864)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot
Copy link

GH-21513 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 16, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2020
@terryjreedy @miss-islington
bpo-41300: IDLE - save files with non-ascii chars (pythonGH-21512)
8261fe2 
Fix regression released in 3.9.0b4 and 3.8.4.
(cherry picked from commit 38d3864)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot
Copy link

GH-21514 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jul 16, 2020
@miss-islington @terryjreedy
bpo-41300: IDLE - save files with non-ascii chars (GH-21512)
5a7aa28 
Fix regression released in 3.9.0b4 and 3.8.4.
(cherry picked from commit 38d3864)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit that referenced this pull request Jul 16, 2020
@miss-islington @terryjreedy
[3.8] bpo-41300: IDLE - save files with non-ascii chars (GH-21512)
ffeb920 
Fix regression released in 3.9.0b4 and 3.8.4.
(cherry picked from commit 38d3864)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.9 has failed when building commit 5a7aa28.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/720/builds/179) and take a look at the build logs.
  4. Check if the failure is related to this commit (5a7aa28) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/720/builds/179

Failed tests:

  • test_asyncio

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_asyncio/test_tasks.py", line 3482, in test_run_coroutine_threadsafe_with_timeout
    self.loop.run_until_complete(future)
AssertionError: TimeoutError not raised

@terryjreedy
Copy link
Member Author

False positive due to time out after 25 min.
test_cancel_make_subprocess_transport_exec (test.test_asyncio.test_subprocess.SubprocessMultiLoopWatcherTests) ... *** Error code 1

arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@terryjreedy @arun-mani-j
bpo-41300: IDLE - save files with non-ascii chars (pythonGH-21512)
76e900c 
Fix regression released in 3.9.0b4 and 3.8.4.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@terryjreedy @shihai1991
bpo-41300: IDLE - save files with non-ascii chars (pythonGH-21512)
1349c97 
Fix regression released in 3.9.0b4 and 3.8.4.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@terryjreedy @shihai1991
bpo-41300: IDLE - save files with non-ascii chars (pythonGH-21512)
fdf5d39 
Fix regression released in 3.9.0b4 and 3.8.4.
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@terryjreedy
bpo-41300: IDLE - save files with non-ascii chars (pythonGH-21512)
ca5933a 
Fix regression released in 3.9.0b4 and 3.8.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@terryjreedy terryjreedy

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni