Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41205: Document Decimal power 0 to the 0 #21386

Merged
merged 5 commits into from
Jul 19, 2020
Merged

bpo-41205: Document Decimal power 0 to the 0 #21386

merged 5 commits into from
Jul 19, 2020

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Jul 8, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 8, 2020
@skrah skrah requested a review from mdickinson July 8, 2020 07:08
mdickinson
mdickinson suggested changes Jul 8, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nitpicky request to remove the extra blank lines introduced in this PR, and one suggested minor wording change.

Doc/library/decimal.rst Outdated Show resolved Hide resolved
Doc/library/decimal.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@srinivasreddy
Copy link
Contributor Author

@mdickinson ✅ . Thanks.

mdickinson
mdickinson approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! LGTM. I'll leave this open for a bit in case @skrah or @rhettinger wants to comment.

@skrah
Copy link
Contributor

skrah commented Jul 8, 2020

Looks good, thanks!

rhettinger
rhettinger requested changes Jul 12, 2020
View reviewed changes
Doc/library/decimal.rst Outdated
@@ -1355,7 +1355,9 @@ In addition to the three supplied contexts, new contexts can be created with the
must be integral. The result will be inexact unless ``y`` is integral and
the result is finite and can be expressed exactly in 'precision' digits.
The rounding mode of the context is used. Results are always correctly-rounded
in the Python version.
in the Python version. ``Decimal(0) ** Decimal(0)`` results in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a blank line so this gets its own paragraph.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@srinivasreddy
Copy link
Contributor Author

@rhettinger Done Raymond. Thanks!!!

@skrah skrah requested a review from rhettinger July 19, 2020 11:01
@skrah
Copy link
Contributor

skrah commented Jul 19, 2020

@rhettinger's comment has been addressed, so I think we can merge.

@skrah skrah merged commit 10e4664 into python:master Jul 19, 2020
@miss-islington
Copy link
Contributor

Thanks @srinivasreddy for the PR, and @skrah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2020
@srinivasreddy @miss-islington
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
c2564a5 
Co-authored-by: Mark Dickinson <[email protected]>
(cherry picked from commit 10e4664)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 19, 2020
@bedevere-bot
Copy link

GH-21547 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-21548 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2020
@srinivasreddy @miss-islington
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
cf9dc74 
Co-authored-by: Mark Dickinson <[email protected]>
(cherry picked from commit 10e4664)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
miss-islington added a commit that referenced this pull request Jul 19, 2020
@miss-islington @srinivasreddy
bpo-41205: Document Decimal power 0 to the 0 (GH-21386)
8831162 
Co-authored-by: Mark Dickinson <[email protected]>
(cherry picked from commit 10e4664)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
miss-islington added a commit that referenced this pull request Jul 19, 2020
@miss-islington @srinivasreddy
bpo-41205: Document Decimal power 0 to the 0 (GH-21386)
dac8a3a 
Co-authored-by: Mark Dickinson <[email protected]>
(cherry picked from commit 10e4664)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@srinivasreddy @mdickinson @arun-mani-j
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
70cb661 
Co-authored-by: Mark Dickinson <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@srinivasreddy @mdickinson @shihai1991
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
de846a1 
Co-authored-by: Mark Dickinson <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@srinivasreddy @mdickinson @shihai1991
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
64d261a 
Co-authored-by: Mark Dickinson <[email protected]>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@srinivasreddy @mdickinson
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
31ecf5a 
Co-authored-by: Mark Dickinson <[email protected]>
@JD-Veiga JD-Veiga mannequin mentioned this pull request May 10, 2023
Closed
@jstasiak jstasiak mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

@skrah skrah skrah approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@srinivasreddy @bedevere-bot @skrah @miss-islington @mdickinson @rhettinger @the-knights-who-say-ni