Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41180: Audit code.__new__ when unmarshalling #21271

Merged
merged 1 commit into from
Jul 3, 2020
Merged

bpo-41180: Audit code.__new__ when unmarshalling #21271

merged 1 commit into from
Jul 3, 2020

Conversation

tkmikan
Copy link
Contributor

@tkmikan tkmikan commented Jul 2, 2020 •
edited by bedevere-bot
Loading

@tkmikan tkmikan requested a review from tiran as a code owner July 2, 2020 03:24
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@tkmikan

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

zooba
zooba requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bigger comment in the tracker, but let's just audit once inside PyCode_NewWithPosOnlyArgs.

Could you move the call into there and delete the other ones?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

zooba
zooba approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on the tracker, we do want the event raised here to avoid calls that we know are coming via built-in mechanisms.

@zooba zooba merged commit d160e0f into python:master Jul 3, 2020
@miss-islington
Copy link
Contributor

Thanks @tkmikan for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @tkmikan and @zooba, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d160e0f8e283d0a8737644588b38e8c6a07c134f 3.9

@bedevere-bot
Copy link

GH-21300 is a backport of this pull request to the 3.8 branch.

@zooba zooba added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels Jul 3, 2020
@miss-islington
Copy link
Contributor

Thanks @tkmikan for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2020
@tkmikan @miss-islington
bpo-41180: Audit code.__new__ when unmarshalling (pythonGH-21271)
d030525 
(cherry picked from commit d160e0f)

Co-authored-by: tkmikan <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 3, 2020
@bedevere-bot
Copy link

GH-21301 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2020
@tkmikan @miss-islington
bpo-41180: Audit code.__new__ when unmarshalling (pythonGH-21271)
28f2f23 
(cherry picked from commit d160e0f)

Co-authored-by: tkmikan <[email protected]>
miss-islington added a commit that referenced this pull request Jul 3, 2020
@miss-islington @tkmikan
bpo-41180: Audit code.__new__ when unmarshalling (GH-21271)
c1d9165 
(cherry picked from commit d160e0f)

Co-authored-by: tkmikan <[email protected]>
miss-islington added a commit that referenced this pull request Jul 3, 2020
@miss-islington @tkmikan
bpo-41180: Audit code.__new__ when unmarshalling (GH-21271)
1c77654 
(cherry picked from commit d160e0f)

Co-authored-by: tkmikan <[email protected]>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@tkmikan @arun-mani-j
bpo-41180: Audit code.__new__ when unmarshalling (pythonGH-21271)
ff5345e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees

@zooba zooba

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tkmikan @the-knights-who-say-ni @bedevere-bot @miss-islington @zooba