Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-40448: ensurepip: Do not use cache (GH-19812) #20893

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 15, 2020

ensurepip optionally installs or upgrades 'pip' and 'setuptools' using
the version of those modules bundled with Python. The internal PIP
installation routine by default temporarily uses its cache, if it
exists. This is undesirable as Python builds and installations may be
independent of the user running the build, whilst PIP cache location
is dependent on the user's environment and outside of the build
environment.

At the same time, there's no value in using the cache while installing
bundled modules.

This change disables PIP caching when used in ensurepip.
(cherry picked from commit 4a3a682)

Co-authored-by: Krzysztof Konopko [email protected]

https://bugs.python.org/issue40448

Automerge-Triggered-By: @ned-deily

ensurepip optionally installs or upgrades 'pip' and 'setuptools' using
the version of those modules bundled with Python.  The internal PIP
installation routine by default temporarily uses its cache, if it
exists.  This is undesirable as Python builds and installations may be
independent of the user running the build, whilst PIP cache location
is dependent on the user's environment and outside of the build
environment.

At the same time, there's no value in using the cache while installing
bundled modules.

This change disables PIP caching when used in ensurepip.
(cherry picked from commit 4a3a682)

Co-authored-by: Krzysztof Konopko <[email protected]>
@miss-islington
Copy link
Contributor Author

@kkonopko and @ned-deily: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 9a0624a into python:3.9 Jun 15, 2020
@miss-islington miss-islington deleted the backport-4a3a682-3.9 branch June 15, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants