Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40950: Port nis module to multiphase initialization #20811

Merged
merged 9 commits into from
Jun 12, 2020
Merged

bpo-40950: Port nis module to multiphase initialization #20811

merged 9 commits into from
Jun 12, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jun 11, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner June 11, 2020 15:22
vstinner
vstinner reviewed Jun 11, 2020
View reviewed changes
Modules/nismodule.c Outdated Show resolved Hide resolved
Modules/nismodule.c Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Core and Builtins/2020-06-12-00-12-28.bpo-40950.tzMy7m.rst Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Jun 11, 2020
View reviewed changes
Modules/nismodule.c Outdated Show resolved Hide resolved
@corona10 corona10 requested a review from vstinner June 11, 2020 16:16
corona10
corona10 commented Jun 11, 2020
View reviewed changes
Copy link
Member Author

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner
Thanks for the review!
Updated!

vstinner
vstinner reviewed Jun 11, 2020
View reviewed changes
Modules/nismodule.c Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Jun 11, 2020
View reviewed changes
Modules/nismodule.c Outdated Show resolved Hide resolved
Modules/nismodule.c Outdated Show resolved Hide resolved
@corona10 corona10 requested a review from vstinner June 11, 2020 17:43
@corona10
Copy link
Member Author

@shihai1991 Can you please take a look?

vstinner
vstinner approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10 corona10 changed the title bpo-40950: Apply PEP 3121 to nis module bpo-40950: Port nis module to multiphase initialization Jun 12, 2020
@corona10 corona10 merged commit ddef3bd into python:master Jun 12, 2020
@corona10 corona10 deleted the bpo-40950 branch June 13, 2020 01:49
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@corona10 @arun-mani-j
bpo-40950: Port nis module to multiphase initialization (pythonGH-20811)
99f1d1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihai1991 shihai1991 shihai1991 left review comments

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot