bpo-40798: Generate a different message for already removed elements #20483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remilapeyre
suggested changes
May 28, 2020
remilapeyre
suggested changes
May 28, 2020
remilapeyre
approved these changes
May 28, 2020
|
Thanks for the guidance @remilapeyre! |
|
Thanks @DahlitzFlorian I like it a lot! Could you just add the new string to |
|
Thanks for the feedback and pointing me at the translation part, @JulienPalard! |
JulienPalard
approved these changes
May 30, 2020
|
Thanks @DahlitzFlorian! I'll be happy to see it in prod (and translated!)! |
JulienPalard
added
needs backport to 3.8
needs backport to 3.9
|
Thanks @DahlitzFlorian for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9. |
|
GH-20531 is a backport of this pull request to the 3.9 branch. |
|
GH-20532 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 30, 2020
…ythonGH-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 30, 2020
…ythonGH-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <[email protected]>
|
GH-20533 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
May 30, 2020
…H-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 30, 2020
…H-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 30, 2020
…H-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <[email protected]>
CuriousLearner
added a commit
to CuriousLearner/cpython
that referenced
this pull request
May 30, 2020
* 'master' of github.com:python/cpython: (497 commits) bpo-40061: Fix a possible refleak in _asynciomodule.c (pythonGH-19748) bpo-40798: Generate a different message for already removed elements (pythonGH-20483) closes bpo-29017: Update the bindings for Qt information with PySide2 (pythonGH-20149) bpo-39885: Make IDLE context menu cut and copy work again (pythonGH-18951) bpo-29882: Add an efficient popcount method for integers (python#771) Further de-linting of zoneinfo module (python#20499) bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros (pythonGH-20435) Indicate that abs() method accept argument that implement __abs__(), just like call() method in the docs (pythonGH-20509) bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. (pythongh-17620) bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448) bpo-30064: Properly skip unstable loop.sock_connect() racing test (pythonGH-20494) Note the output ordering of combinatoric functions (pythonGH-19732) bpo-40474: Updated coverage.yml to better report coverage stats (python#19851) bpo-40806: Clarify that itertools.product immediately consumes its inpt (pythonGH-20492) bpo-1294959: Try to clarify the meaning of platlibdir (pythonGH-20332) bpo-37878: PyThreadState_DeleteCurrent() was not removed (pythonGH-20489) bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time (pythonGH-20493) bpo-40755: Add missing multiset operations to Counter() (pythonGH-20339) bpo-25920: Remove socket.getaddrinfo() lock on macOS (pythonGH-20177) bpo-40275: Fix test.support.threading_helper (pythonGH-20488) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@remilapeyre I did not include a news entry as it only affects the documentation.
https://bugs.python.org/issue40798