Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-84443: SSLSocket.recv_into() shouldn't require __len__ #20310

Merged

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented May 22, 2020

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happen if keep nbytes = None?

@ambv ambv removed the needs backport to 3.9 only security fixes label May 17, 2022
@ambv
Copy link
Contributor

ambv commented May 17, 2022

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@arhadthedev arhadthedev changed the title bpo-40262: SSLSocket.recv_into() shouldn't require __len__ gh-84443: SSLSocket.recv_into() shouldn't require __len__ May 6, 2023
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Nov 27, 2023
@serhiy-storchaka serhiy-storchaka merged commit 812360f into python:main Nov 27, 2023
31 checks passed
@miss-islington-app
Copy link

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 812360fddda86d7aff5823f529ab720f57ddc411 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2023
…h itemsize != 1 (pythonGH-20310)

It is also no longer use __len__().

(cherry picked from commit 812360f)

Co-authored-by: Zackery Spytz <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 27, 2023

GH-112458 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 27, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 27, 2023
…col with itemsize != 1 (pythonGH-20310)

It is also no longer use __len__().

(cherry picked from commit 812360f)

Co-authored-by: Zackery Spytz <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 27, 2023

GH-112459 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 27, 2023
serhiy-storchaka added a commit that referenced this pull request Nov 27, 2023
…th itemsize != 1 (GH-20310) (GH-112458)

It is also no longer use __len__().

(cherry picked from commit 812360f)

Co-authored-by: Zackery Spytz <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Nov 27, 2023
…th itemsize != 1 (GH-20310) (GH-112459)

It is also no longer use __len__().

(cherry picked from commit 812360f)

Co-authored-by: Zackery Spytz <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…h itemsize != 1 (pythonGH-20310)

It is also no longer use __len__().

Co-authored-by: Serhiy Storchaka <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…h itemsize != 1 (pythonGH-20310)

It is also no longer use __len__().

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants