-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-84443: SSLSocket.recv_into() shouldn't require __len__ #20310
gh-84443: SSLSocket.recv_into() shouldn't require __len__ #20310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happen if keep nbytes = None
?
This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today. |
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to
|
…h itemsize != 1 (pythonGH-20310) It is also no longer use __len__(). (cherry picked from commit 812360f) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
GH-112458 is a backport of this pull request to the 3.12 branch. |
…col with itemsize != 1 (pythonGH-20310) It is also no longer use __len__(). (cherry picked from commit 812360f) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
GH-112459 is a backport of this pull request to the 3.11 branch. |
…th itemsize != 1 (GH-20310) (GH-112458) It is also no longer use __len__(). (cherry picked from commit 812360f) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
…th itemsize != 1 (GH-20310) (GH-112459) It is also no longer use __len__(). (cherry picked from commit 812360f) Co-authored-by: Zackery Spytz <[email protected]>
…h itemsize != 1 (pythonGH-20310) It is also no longer use __len__(). Co-authored-by: Serhiy Storchaka <[email protected]>
…h itemsize != 1 (pythonGH-20310) It is also no longer use __len__(). Co-authored-by: Serhiy Storchaka <[email protected]>
https://bugs.python.org/issue40262