Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40716: Improve error messages for trailing comma on from import #20294

Merged
merged 1 commit into from
May 21, 2020
Merged

bpo-40716: Improve error messages for trailing comma on from import #20294

merged 1 commit into from
May 21, 2020

Conversation

isidentical
Copy link
Sponsor Member

@isidentical isidentical commented May 21, 2020 •
edited
Loading

@pablogsal
Copy link
Member

Wrong issue number?

@isidentical
Copy link
Sponsor Member Author

Wrong issue number?

yep! It should be 40716

@isidentical isidentical changed the title bpo-40176: Improve error messages for trailing comma on from import bpo-40716: Improve error messages for trailing comma on from import May 21, 2020
lysnikolaou
lysnikolaou reviewed May 21, 2020
View reviewed changes
Grammar/python.gram Outdated Show resolved Hide resolved
@pablogsal
Copy link
Member

You need to regenerate the parser 😉

pablogsal
pablogsal reviewed May 21, 2020
View reviewed changes
Grammar/python.gram Outdated Show resolved Hide resolved
lysnikolaou
lysnikolaou approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🚀

@lysnikolaou lysnikolaou added the needs backport to 3.9 only security fixes label May 21, 2020
@pablogsal pablogsal merged commit 72e0aa2 into python:master May 21, 2020
@miss-islington
Copy link
Contributor

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @isidentical and @pablogsal, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 72e0aa2fd2b9c6da2caa5a9ef54f6495fc2890b0 3.9

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request May 21, 2020
@isidentical @pablogsal
[3.9] bpo-40176: Improve error messages for trailing comma on from im…
d0cffb2 
…port (pythonGH-20294)

(cherry picked from commit 72e0aa2)

Co-authored-by: Batuhan Taskaya <[email protected]>
@bedevere-bot
Copy link

GH-20302 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 21, 2020
pablogsal added a commit that referenced this pull request May 21, 2020
@pablogsal @isidentical
[3.9] bpo-40176: Improve error messages for trailing comma on from im…
275d7e1 
…port (GH-20294) (GH-20302)

(cherry picked from commit 72e0aa2)

Co-authored-by: Batuhan Taskaya <[email protected]>
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@isidentical @arturoescaip
bpo-40176: Improve error messages for trailing comma on from import (p…
856fe24 
…ythonGH-20294)
@isidentical isidentical mentioned this pull request May 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

@pablogsal pablogsal

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@isidentical @pablogsal @miss-islington @bedevere-bot @lysnikolaou @the-knights-who-say-ni