bpo-9216: hashlib usedforsecurity fixes #20258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
bpo9216-fix
branch
2 times, most recently
from
71887fe
to
0838bd5
Compare
func:`hashlib.new` passed ``usedforsecurity`` to OpenSSL EVP constructor ``_hashlib.new()``. test_hashlib and test_smtplib handle strict security policy better. Signed-off-by: Christian Heimes <[email protected]>
gpshead
reviewed
May 22, 2020
| @@ -0,0 +1,3 @@ | |||
| func:`hashlib.new` passed ``usedforsecurity`` to OpenSSL EVP constructor | |||
There was a problem hiding this comment.
A user reading this shouldn't need to be aware of the internal implementation details behind the Python hashlib "usedforsecurity" construct. I'd just simplify this news entry:
func:`hashlib.new` now passes the ``usedforsecurity`` flag to the internal OpenSSL hash constructors.
and probably omit the final "test_hashlib and test_smtplib handle strict security policy better." part entirely as we don't need a NEWS entry to mention updates to our internal test suite. (though it is harmless to do so)
gpshead
approved these changes
May 22, 2020
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-20320 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2020
func:`hashlib.new` passed ``usedforsecurity`` to OpenSSL EVP constructor ``_hashlib.new()``. test_hashlib and test_smtplib handle strict security policy better. Signed-off-by: Christian Heimes <[email protected]> Automerge-Triggered-By: @tiran (cherry picked from commit 909b571) Co-authored-by: Christian Heimes <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 22, 2020
func:`hashlib.new` passed ``usedforsecurity`` to OpenSSL EVP constructor ``_hashlib.new()``. test_hashlib and test_smtplib handle strict security policy better. Signed-off-by: Christian Heimes <[email protected]> Automerge-Triggered-By: @tiran (cherry picked from commit 909b571) Co-authored-by: Christian Heimes <[email protected]>
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
func:`hashlib.new` passed ``usedforsecurity`` to OpenSSL EVP constructor ``_hashlib.new()``. test_hashlib and test_smtplib handle strict security policy better. Signed-off-by: Christian Heimes <[email protected]> Automerge-Triggered-By: @tiran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
func:
hashlib.newpassedusedforsecurityto OpenSSL EVP constructor_hashlib.new(). test_hashlib and test_smtplib handle strict securitypolicy better.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue9216
Automerge-Triggered-By: @tiran