Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40334: Produce better error messages on invalid targets #20106

Merged
merged 24 commits into from
Jun 18, 2020
Merged

bpo-40334: Produce better error messages on invalid targets #20106

merged 24 commits into from
Jun 18, 2020

Commits on May 15, 2020

  1. bpo-40334: Produce better error messages on invalid targets 

    The following error messages get produced:
- `cannot delete ...` for invalid `del` targets
- `... is an illegal 'for' target` for invalid targets in for
  statements
- `... is an illegal 'with' target` for invalid targets in
  with statements

Additionally a few `cut`s were added in various places before the
invocation of the `invalid_*` rule, in order to speed things
up.
    @lysnikolaou
    lysnikolaou committed May 15, 2020
    Configuration menu
    Copy the full SHA
    0dfaa22 View commit details
    Browse the repository at this point in the history

  2. Fix test_exceptions

    @lysnikolaou
    lysnikolaou committed May 15, 2020
    Configuration menu
    Copy the full SHA
    d4a9dd6 View commit details
    Browse the repository at this point in the history

  3. 📜🤖 Added by blurb_it.

    @blurb-it
    blurb-it[bot] authored May 15, 2020
    Configuration menu
    Copy the full SHA
    72a1339 View commit details
    Browse the repository at this point in the history

  4. Produce the same error messages with the old parser for with and for … 

    …targets
    @lysnikolaou
    lysnikolaou committed May 15, 2020
    Configuration menu
    Copy the full SHA
    1b6cf0b View commit details
    Browse the repository at this point in the history

  5. Add invalid_group rule

    @lysnikolaou
    lysnikolaou committed May 15, 2020
    Configuration menu
    Copy the full SHA
    1ad3819 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2020

  1. Update Grammar/python.gram 

    Co-authored-by: Pablo Galindo <[email protected]>
    @lysnikolaou @pablogsal
    lysnikolaou and pablogsal authored May 16, 2020
    Configuration menu
    Copy the full SHA
    6f30315 View commit details
    Browse the repository at this point in the history

  2. Update Parser/pegen/pegen.c 

    Co-authored-by: Pablo Galindo <[email protected]>
    @lysnikolaou @pablogsal
    lysnikolaou and pablogsal authored May 16, 2020
    Configuration menu
    Copy the full SHA
    f750aba View commit details
    Browse the repository at this point in the history

  3. Address Guido's feedback 

    Correctly identify invalid targets, when there are multiple context
managers in a with statement, avoid SEGFAULT in invalid for targets
and improve paremeter naming in _PyPegen_get_invalid_target.
    @lysnikolaou
    lysnikolaou committed May 16, 2020
    Configuration menu
    Copy the full SHA
    132178f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2020

  1. Inline _PyPegen_get_invalid_for_target

    @lysnikolaou
    lysnikolaou committed May 17, 2020
    Configuration menu
    Copy the full SHA
    17cc4bc View commit details
    Browse the repository at this point in the history

  2. Revert inlining

    @lysnikolaou
    lysnikolaou committed May 17, 2020
    Configuration menu
    Copy the full SHA
    def0f3d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into targets-errors

    @pablogsal
    pablogsal committed May 17, 2020
    Configuration menu
    Copy the full SHA
    ee3524b View commit details
    Browse the repository at this point in the history

  4. Fix searching for invalid for targets, by visiting Compare nodes in _… 

    …PyPegen_get_invalid_target
    @lysnikolaou
    lysnikolaou committed May 17, 2020
    Configuration menu
    Copy the full SHA
    4959a12 View commit details
    Browse the repository at this point in the history

  5. Call RAISE_SYNTAX_ERROR instead of returning NULL, when no invalid fo… 

    …r target was found
    @lysnikolaou
    lysnikolaou committed May 17, 2020
    Configuration menu
    Copy the full SHA
    dd1d8c8 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Merge branch 'master' into targets-errors

    @lysnikolaou
    lysnikolaou committed May 18, 2020
    Configuration menu
    Copy the full SHA
    24d63fb View commit details
    Browse the repository at this point in the history

  2. Replace is_del and is_for args with an enum

    @lysnikolaou
    lysnikolaou committed May 18, 2020
    Configuration menu
    Copy the full SHA
    c1cf8e6 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Only return an invalid target, when the comparison is an In comparison

    @lysnikolaou
    lysnikolaou committed May 20, 2020
    Configuration menu
    Copy the full SHA
    06798ff View commit details
    Browse the repository at this point in the history

  2. Fix bug

    @lysnikolaou
    lysnikolaou committed May 20, 2020
    Configuration menu
    Copy the full SHA
    ef7fe3a View commit details
    Browse the repository at this point in the history

Commits on May 23, 2020

  1. Merge branch 'master' into targets-errors

    @lysnikolaou
    lysnikolaou committed May 23, 2020
    Configuration menu
    Copy the full SHA
    efabcc9 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Merge branch 'master' into targets-errors

    @lysnikolaou
    lysnikolaou committed May 26, 2020
    Configuration menu
    Copy the full SHA
    6d41c55 View commit details
    Browse the repository at this point in the history

  2. Minor refactoring

    @lysnikolaou
    lysnikolaou committed May 26, 2020
    Configuration menu
    Copy the full SHA
    82486c1 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Merge branch 'master' into targets-errors

    @lysnikolaou
    lysnikolaou committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    705d55b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into targets-errors

    @lysnikolaou
    lysnikolaou committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    f0f934d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Merge branch 'master' into targets-errors

    @lysnikolaou
    lysnikolaou committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    ede107e View commit details
    Browse the repository at this point in the history

  2. Add CHECK* checks to GET_INVALID_*TARGET macros

    @lysnikolaou
    lysnikolaou committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    55b5327 View commit details
    Browse the repository at this point in the history