Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'exception happened' to 'exception occurred' in two places #19767

Merged
merged 1 commit into from
May 1, 2020
Merged

Change 'exception happened' to 'exception occurred' in two places #19767

merged 1 commit into from
May 1, 2020

Conversation

doersino
Copy link
Contributor

Justification: The phrase "Exception happened" occurs twice in the code base, while "Exception occurred" occurs 30 times.

Since this is really only a cosmetic change akin to a typo fix, I didn't file an issue.

gvanrossum
gvanrossum approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like this consistency.

@gvanrossum gvanrossum merged commit 8bcfd31 into python:master May 1, 2020
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doersino @bedevere-bot @gvanrossum @the-knights-who-say-ni