bpo-40275: Move transient_internet from test.support to socket_helper #19711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
approved these changes
Apr 27, 2020
Lib/test/support/socket_helper.py
Outdated
| def transient_internet(resource_name, *, timeout=_NOT_SET, errnos=()): | ||
| """Return a context manager that raises ResourceDenied when various issues | ||
| with the Internet connection manifest themselves as exceptions.""" | ||
| import socket |
There was a problem hiding this comment.
It's already imported at top-level.
serhiy-storchaka
requested review from
berkerpeksag,
tiran and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40275