Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-23082: Better error message for PurePath.relative_to() from pathlib #19611

Merged
merged 3 commits into from
May 25, 2020
Merged

bpo-23082: Better error message for PurePath.relative_to() from pathlib #19611

merged 3 commits into from
May 25, 2020
+6 −2

Conversation

rotuna
Copy link
Contributor

@rotuna rotuna commented Apr 19, 2020 •
edited by bedevere-bot
Loading

Changed the error message to be more informative and updated the docs accordingly.

https://bugs.python.org/issue23082

Better error for PurePath.relative_to() from pathlib
b979a2f 
Changed the error message to be more informative and updated the docs accordingly.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rotuna

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@rotuna
Copy link
Contributor Author

rotuna commented Apr 22, 2020

@zooba Could you please review this PR?

@csabella csabella requested a review from pitrou April 23, 2020 12:04
zooba
zooba reviewed Apr 28, 2020
View reviewed changes
Lib/pathlib.py Show resolved Hide resolved
@zooba
Copy link
Member

zooba commented Apr 28, 2020

Sorry for the delay - I had it flagged to follow-up, but life.

Pinging me on GitHub doesn't work either, btw (too many notifications; too hard to filter them). If you need my attention, please post on the bug.

@idomic
Copy link
Contributor

idomic commented May 24, 2020

The PR looks good pinging on the bug's page

@zooba zooba merged commit 4483253 into python:master May 25, 2020
@zooba zooba added the needs backport to 3.9 only security fixes label May 25, 2020
@miss-islington
Copy link
Contributor

Thanks @rotuna for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2020
@rotuna @miss-islington
bpo-23082: Better error message for PurePath.relative_to() from pathl…
0149274 
…ib (pythonGH-19611)

Co-authored-by: Sadhana Srinivasan <[email protected]>
(cherry picked from commit 4483253)

Co-authored-by: Rotuna <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 25, 2020
@bedevere-bot
Copy link

GH-20395 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 25, 2020
@miss-islington @rotuna
bpo-23082: Better error message for PurePath.relative_to() from pathl…
318a18e 
…ib (GH-19611)

Co-authored-by: Sadhana Srinivasan <[email protected]>
(cherry picked from commit 4483253)

Co-authored-by: Rotuna <[email protected]>
domragusa added a commit to domragusa/cpython that referenced this pull request May 28, 2020
@domragusa
resolve conflicts with pythonGH-19611
6d721a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rotuna @the-knights-who-say-ni @zooba @idomic @miss-islington @bedevere-bot