Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35967: Make test_platform.test_uname_processor more lenient to satisfy build bots. #19544

Merged
merged 3 commits into from
Apr 15, 2020
Merged

bpo-35967: Make test_platform.test_uname_processor more lenient to satisfy build bots. #19544

merged 3 commits into from
Apr 15, 2020

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Apr 15, 2020

In GH-12824, I added a test to capture the status quo expectation of platform.uname.processor. Then sir bedevere informed me that the buildbots are failing. This patch is intended to address that failure.

https://bugs.python.org/issue35967

Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jaraco. I would suggest updating the title of the PR to refer to the specific test being changed, e.g. Make test_platform.test_uname_processor .... I also have a couple of minor suggestions regarding the test itself.

Lib/test/test_platform.py Outdated Show resolved Hide resolved
Lib/test/test_platform.py Outdated Show resolved Hide resolved
@aeros aeros requested a review from malemburg April 15, 2020 19:57
@aeros
Copy link
Contributor

aeros commented Apr 15, 2020

Also, I didn't look through all of the buildbot failures, but my results above are consistent with the raspbian failure:

======================================================================
FAIL: test_uname_processor (test.test_platform.PlatformTest)
On some systems, the processor must match the output
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/buildbot/workers/3.x.gps-raspbian/build/Lib/test/test_platform.py", line 172, in test_uname_processor
    self.assertEqual(
AssertionError: '' != 'unknown'

@jaraco jaraco changed the title bpo-35967: Make test more lenient to satisfy build bots. bpo-35967: Make test_platform.test_uname_processor more lenient to satisfy build bots. Apr 15, 2020
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 15, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit d1fe7ee 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 15, 2020
@gpshead gpshead self-requested a review April 15, 2020 20:42
@jaraco
Copy link
Member Author

jaraco commented Apr 15, 2020

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

TIL

@jaraco jaraco merged commit e72cbcb into python:master Apr 15, 2020
@jaraco jaraco deleted the bugfix/35967-more-lenient-test branch April 15, 2020 23:55
@jaraco
Copy link
Member Author

jaraco commented Apr 16, 2020

It seems to me the remaining buildbot failures were due to spurious failures unrelated to this change, so I'm pretty sure this change works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants