-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-35967: Make test_platform.test_uname_processor more lenient to satisfy build bots. #19544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jaraco. I would suggest updating the title of the PR to refer to the specific test being changed, e.g. Make test_platform.test_uname_processor ...
. I also have a couple of minor suggestions regarding the test itself.
Also, I didn't look through all of the buildbot failures, but my results above are consistent with the raspbian failure:
|
Co-Authored-By: Kyle Stanley <[email protected]>
TIL |
It seems to me the remaining buildbot failures were due to spurious failures unrelated to this change, so I'm pretty sure this change works. |
In GH-12824, I added a test to capture the status quo expectation of
platform.uname.processor
. Then sir bedevere informed me that the buildbots are failing. This patch is intended to address that failure.https://bugs.python.org/issue35967