Simplify code in warnings modules #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metaprogramming a list of attributes was excessive, and made the code less readable and slower.
|
@alex, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @tiran and @birkenfeld to be potential reviewers. |
dstufft
reviewed
Jun 4, 2017
| @@ -397,9 +397,13 @@ class WarningMessage(object): | |||
|
|
|||
| def __init__(self, message, category, filename, lineno, file=None, | |||
| line=None, source=None): | |||
| local_values = locals() | |||
| for attr in self._WARNING_DETAILS: | |||
There was a problem hiding this comment.
Is this the only use of _WARNING_DETAILS? Does it make sense to just get rid of it?
There was a problem hiding this comment.
No, it's not. There's a usage in Lib/test/support/__init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metaprogramming a list of attributes was excessive, and made the code less readable and slower.