[docs] Clarify a guarantee of the logging module. #19132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no additional arguments are passed to logging.debug() and related methods, no % operation is performed on the passed in message.
gpshead
added
docs
|
This simple documentation addition is motivated by someone thinking that this isn't a guarantee of the logging module because it isn't mentioned in the docs. It has been this implemented this way (and I can't imagine why it would ever be otherwise). implemented here https://github.com/python/cpython/blob/master/Lib/logging/__init__.py#L368 with more details in the comment here https://github.com/python/cpython/blob/master/Lib/logging/__init__.py#L293 |
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 24, 2020
When no additional arguments are passed to logging.debug() and related methods, no % operation is performed on the passed in message. (cherry picked from commit 9b8e74c) Co-authored-by: Gregory P. Smith <[email protected]>
|
GH-19138 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 24, 2020
When no additional arguments are passed to logging.debug() and related methods, no % operation is performed on the passed in message. (cherry picked from commit 9b8e74c) Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no additional arguments are passed to logging.debug() and related
methods, no % operation is performed on the passed in message.