bpo-39930: Convert error to warning for more silent failure #18921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
changed the title
zooba
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Enough buildbots have passed that I'm happy with this. The Win7 ones are known to be broken on master. |
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
Sorry @zooba, I had trouble checking out the |
|
GH-18922 is a backport of this pull request to the 3.7 branch. |
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 11, 2020
…-18921) Makes it an error to create a layout without vcruntime DLL (cherry picked from commit fde44ae) Co-authored-by: Steve Dower <[email protected]>
|
GH-18923 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 11, 2020
…-18921) Makes it an error to create a layout without vcruntime DLL (cherry picked from commit fde44ae) Co-authored-by: Steve Dower <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 11, 2020
Makes it an error to create a layout without vcruntime DLL (cherry picked from commit fde44ae) Co-authored-by: Steve Dower <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 11, 2020
Makes it an error to create a layout without vcruntime DLL (cherry picked from commit fde44ae) Co-authored-by: Steve Dower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39930