Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39789: Update Windows release build machines to latest versions #18695

Merged
merged 6 commits into from
Feb 29, 2020
Merged

bpo-39789: Update Windows release build machines to latest versions #18695

merged 6 commits into from
Feb 29, 2020

Conversation

zooba
Copy link
Member

@zooba zooba commented Feb 28, 2020 •
edited
Loading

Also fixes some Nuget build issues.

https://bugs.python.org/issue39789

@codecov
Copy link

codecov bot commented Feb 28, 2020 •
edited
Loading

Codecov Report

Merging #18695 into master will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18695       +/-   ##
===========================================
+ Coverage   82.13%   83.21%    +1.08%     
===========================================
  Files        1956     1571      -385     
  Lines      589924   415192   -174732     
  Branches    44479    44479               
===========================================
- Hits       484521   345515   -139006     
+ Misses      95757    60032    -35725     
+ Partials     9646     9645        -1
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 436 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916895f...f59357d. Read the comment docs.

@zooba zooba requested a review from a team as a code owner February 28, 2020 23:47
@zooba zooba merged commit 03153dd into python:master Feb 29, 2020
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-18697 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 03153dd1459fab94f294a118ed1525e34d58601a 3.7

@zooba zooba deleted the windows-release branch February 29, 2020 00:22
miss-islington added a commit that referenced this pull request Feb 29, 2020
@miss-islington @zooba
bpo-39789: Update Windows release build machines to VS 2019 (GH-18695)
45c4112 
Also fixes some potential Nuget build issues.
(cherry picked from commit 03153dd)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni