Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-3950: fix docs for default locale of gettext #18435

Merged
merged 1 commit into from
Feb 10, 2020
Merged

bpo-3950: fix docs for default locale of gettext #18435

merged 1 commit into from
Feb 10, 2020

Conversation

carltyndall
Copy link
Contributor

@carltyndall carltyndall commented Feb 10, 2020

documentation for default locale directory in Doc/library/gettext.rst changed to match gettext implementation line 63.

https://bugs.python.org/issue3950

…text.rst changed to match gettext implementation line 63.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 10, 2020
@gvanrossum gvanrossum changed the title BPO-3950: fix docs for default locale of gettext bpo-3950: fix docs for default locale of gettext Feb 10, 2020
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sitting next to Carl at the PyCascades 2020 sprint. LGTM Carl!

@gvanrossum gvanrossum merged commit d68e0a8 into python:master Feb 10, 2020
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@gvanrossum
Copy link
Member

I'm looking into whether this deserves backporting.

@gvanrossum
Copy link
Member

Yup, the source is the same in 3.8, 3.7, 3.6. I did not search farther back.

@miss-islington
Copy link
Contributor

Thanks @Carl-ty for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @Carl-ty for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
…mentation (pythonGH-18435)

documentation for default locale directory Doc/library/gettext.rst changed to match gettext implementation line 63.
(cherry picked from commit d68e0a8)

Co-authored-by: Carl <[email protected]>
@bedevere-bot
Copy link

GH-18439 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
…mentation (pythonGH-18435)

documentation for default locale directory Doc/library/gettext.rst changed to match gettext implementation line 63.
(cherry picked from commit d68e0a8)

Co-authored-by: Carl <[email protected]>
@bedevere-bot
Copy link

GH-18440 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Feb 10, 2020
…mentation (GH-18435)

documentation for default locale directory Doc/library/gettext.rst changed to match gettext implementation line 63.
(cherry picked from commit d68e0a8)

Co-authored-by: Carl <[email protected]>
miss-islington added a commit that referenced this pull request Feb 10, 2020
…implementation (GH-18435) (GH-18439)

documentation for default locale directory Doc/library/gettext.rst changed to match gettext implementation line 63.
(cherry picked from commit d68e0a8)


Co-authored-by: Carl <[email protected]>


https://bugs.python.org/issue3950



Automerge-Triggered-By: @gvanrossum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants