-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39417: Fix broken link to guide to building venvs #18432
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
I have signed the CLA and am waiting the 1 US Business Day before checking the status on the |
Thanks for your contribution @j9ac9k! Could you put the bugs.python.org issue number in the commit message and PR title as shown here: https://devguide.python.org/pullrequest/#making-good-commits |
sorry for the multiple forced commits, I got a bit configured in the docs with what the format should be of the git commit msg; git commit msg should now be correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CLA is approved.
At PyCascades Sprint, this is good to go. @willingc Please review. |
GH-21383 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit c4a65ed) Co-authored-by: Ogi Moore <[email protected]>
(cherry picked from commit c4a65ed) Co-authored-by: Ogi Moore <[email protected]>
Fix broken link in python packaging user guide
https://bugs.python.org/issue39417