bpo-30495: IDLE: Modernize textview.py with docstrings and PEP8 names #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @louisom to be potential reviewers. |
terryjreedy
changed the title
|
I believe the appveyor failure is correct and the travis success incorrect. I am opening a new issue and will explain there after I download this into a new branch and check for myself. |
terryjreedy
changed the title
terryjreedy
requested changes
May 28, 2017
There was a problem hiding this comment.
See new issue #30495 for why appveyor failure is correct and the fix I am making.
terryjreedy
approved these changes
May 28, 2017
terryjreedy
requested changes
May 28, 2017
| dialog._current_textview.text.get('1.0', '1.end')) | ||
| self.assertEqual( | ||
| printer._Printer__lines[1], | ||
| dialog._current_textview.text.get('2.0', '2.end') |
terryjreedy
approved these changes
May 28, 2017
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jun 11, 2017
…python#1839) Patch by Cheryl Sabella. (cherry picked from commit 0aa0a06)
terryjreedy
added a commit
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.