Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .idea and .iml to .gitignore #1764

Merged
merged 1 commit into from
May 24, 2017
Merged

Add .idea and .iml to .gitignore #1764

merged 1 commit into from
May 24, 2017

Conversation

gfyoung
Copy link
Contributor

@gfyoung gfyoung commented May 23, 2017

These arose when working with the repository in IntelliJ IDE. This is a trivial PR.

@mention-bot
Copy link

@gfyoung, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akheron, @zware and @zooba to be potential reviewers.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@gfyoung
Copy link
Contributor Author

gfyoung commented May 23, 2017

Unfortunately our records indicate you have not signed the CLA.

I signed the CLA two days ago. How long does it take to propagate? Or should I forward the confirmation email to somebody?

@zooba zooba added the trivial label May 24, 2017
@zooba zooba merged commit c0fa4ba into python:master May 24, 2017
@zooba
Copy link
Member

zooba commented May 24, 2017

Thanks!

@gfyoung gfyoung deleted the gitignore-add branch May 24, 2017 16:34
@berkerpeksag
Copy link
Member

Note that a nearly identical PR (see #6) was rejected before because users can use a global .gitignore file (see also bpo-29510 for Eclipse.)

@gfyoung
Copy link
Contributor Author

gfyoung commented May 24, 2017

Fair enough, though I think this comment at the end of the PR here suggests that perhaps that that suggestion should be reconsidered. I see no reason to assume that users have a global .gitignore file configured. That's seem to be just asking for accidental file commits.

@berkerpeksag
Copy link
Member

Using a global .gitignore file is a best practice. That last comment was about syncing .gitignore with .hgignore.

@gfyoung
Copy link
Contributor Author

gfyoung commented May 24, 2017

Best practice but not required. Call me cynical, but I don't expect users to do this (in my case, I was working on a machine other than my own and accidentally committed these changes in another PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants