bpo-39033: Fix NameError in zipimport during hash validation #17588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirkarthi
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
corona10
approved these changes
Dec 13, 2019
ncoghlan
approved these changes
Dec 15, 2019
|
Thanks Nick. I think this can be backported to 3.8 too. This changes the importlib header file and I guess it's allowed to change between bug fix versions. |
|
@tirkarthi yes, the header files can change in bugfix releases. But it does mean backporting will have to be done in manual PRs to get the right bytecode. |
|
Ah yes, thanks Brett I will make a manual backport with the generated header file. |
miss-islington
pushed a commit
that referenced
this pull request
Jan 14, 2020
…H-17588) (GH-17642) Fix `NameError` in `zipimport` during hash validation and add a regression test. (cherry picked from commit 79f02fe) https://bugs.python.org/issue39033
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…H-17588) Patch by Karthikeyan Singaravelan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
NameErrorinzipimportduring hash validation and add a regression test.https://bugs.python.org/issue39033