Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38614: Use support timeout constants #17572

Merged
merged 1 commit into from
Dec 11, 2019
Merged

bpo-38614: Use support timeout constants #17572

merged 1 commit into from
Dec 11, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 11, 2019 •
edited by bedevere-bot
Loading

@vstinner vstinner requested a review from a team as a code owner December 11, 2019 10:44
@vstinner
Copy link
Member Author

Ooops, test_socket failed:

testFamily (test.test_socket.NetworkConnectionAttributesTest) ... Warning -- Unraisable exception

Exception ignored in thread started by: <bound method ThreadableTest.clientRun of <test.test_socket.NetworkConnectionAttributesTest testMethod=testFamily>>

Traceback (most recent call last):

  File "/home/travis/build/python/cpython/Lib/test/test_socket.py", line 379, in clientRun

    self.clientTearDown()

  File "/home/travis/build/python/cpython/Lib/test/test_socket.py", line 5056, in clientTearDown

    self.cli.close()

AttributeError: 'NetworkConnectionAttributesTest' object has no attribute 'cli'

@vstinner vstinner merged commit 7772b1a into python:master Dec 11, 2019
@vstinner vstinner deleted the more_timeouts branch December 11, 2019 21:17
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vstinner @shihai1991
bpo-38614: Use support timeout constants (pythonGH-17572)
c9bc446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot