Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38614: Use test.support.LOOPBACK_TIMEOUT constant #17554

Merged
merged 1 commit into from
Dec 10, 2019
Merged

bpo-38614: Use test.support.LOOPBACK_TIMEOUT constant #17554

merged 1 commit into from
Dec 10, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 10, 2019 •
edited by bedevere-bot
Loading

Replace hardcoded timeout constants in tests with LOOPBACK_TIMEOUT of
test.support, so it's easier to ajdust this timeout for all tests at
once.

https://bugs.python.org/issue38614

@vstinner
bpo-38614: Use test.support.LOOPBACK_TIMEOUT constant
86469fe 
Replace hardcoded timeout constants in tests with LOOPBACK_TIMEOUT of
test.support, so it's easier to ajdust this timeout for all tests at
once.
@vstinner vstinner requested review from 1st1, asvetlov, tiran and a team as code owners December 10, 2019 13:28
@vstinner
Copy link
Member Author

@pablogsal: That's the first subset of changes to use the new test.support timeout constants.

Previously, PR #16964 added constants and used constants in some places. I reworked PR #16964 to only add constant, and that's the first following PR to use one of these constants. More PRs will follow for the other constants. This PR is restricted to LOOPBACK_TIMEOUT and so should be easier to review.

LOOPBACK_TIMEOUT default value is 5 seconds. This PR increases timeouts in modified tests, it doesn't reduce it.

pablogsal
pablogsal approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Previously, PR #16964 added constants and used constants in some places. I reworked PR #16964 to only add constant, and that's the first following PR to use one of these constants. More PRs will follow for the other constants. This PR is restricted to LOOPBACK_TIMEOUT and so should be easier to review.

Thanks for the split, this makes so much easier to review the PR 🎉

@vstinner vstinner merged commit 07871b2 into python:master Dec 10, 2019
@vstinner vstinner deleted the loopback_timeout branch December 10, 2019 19:33
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vstinner @shihai1991
bpo-38614: Use test.support.LOOPBACK_TIMEOUT constant (pythonGH-17554)
10d3788 
Replace hardcoded timeout constants in tests with LOOPBACK_TIMEOUT of
test.support, so it's easier to ajdust this timeout for all tests at
once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @pablogsal @the-knights-who-say-ni @bedevere-bot