Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-21063: Improve module synopsis #17363

Merged
merged 2 commits into from
Nov 25, 2019
Merged

bpo-21063: Improve module synopsis #17363

merged 2 commits into from
Nov 25, 2019

Conversation

GeniusLearner
Copy link
Contributor

@GeniusLearner GeniusLearner commented Nov 23, 2019 •
edited by bedevere-bot
Loading

Cleanup synopsis of modules in documentation.

https://bugs.python.org/issue21063

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 23, 2019
CuriousLearner
CuriousLearner reviewed Nov 23, 2019
View reviewed changes
Copy link
Member

@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've one question mentioned inline. Rest everything looks good to me.

Doc/distutils/apiref.rst Show resolved Hide resolved
@brettcannon brettcannon self-requested a review November 25, 2019 18:32
brettcannon
brettcannon requested changes Nov 25, 2019
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor improvement to (try to) make. Otherwise LGTM!

Doc/distutils/apiref.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@GeniusLearner
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

CuriousLearner
CuriousLearner approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@CuriousLearner
Copy link
Member

Hey @GeniusLearner

Since this is your first contribution, you can put your name in https://github.com/python/cpython/blob/master/Misc/ACKS file which contains list of contributors to the repo, if you prefer.

eamanu
eamanu approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brettcannon brettcannon merged commit f8a6316 into python:master Nov 25, 2019
@miss-islington
Copy link
Contributor

Thanks @GeniusLearner for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot
Copy link

GH-17381 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-17382 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @GeniusLearner and @brettcannon, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f8a6316778faff3991144c3aec4fa92d7b30a72b 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2019
@GeniusLearner @miss-islington
bpo-21063: Improve module synopsis for distutils (pythonGH-17363)
81c6731 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2019
@GeniusLearner @miss-islington
bpo-21063: Improve module synopsis for distutils (pythonGH-17363)
75ba9e1 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <[email protected]>
@brettcannon brettcannon added needs backport to 3.8 only security fixes and removed needs backport to 2.7 needs backport to 3.8 only security fixes labels Nov 25, 2019
@miss-islington
Copy link
Contributor

Thanks @GeniusLearner for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @GeniusLearner and @brettcannon, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f8a6316778faff3991144c3aec4fa92d7b30a72b 3.8

@brettcannon brettcannon added needs backport to 3.8 only security fixes and removed needs backport to 3.8 only security fixes labels Nov 25, 2019
@miss-islington
Copy link
Contributor

Thanks @GeniusLearner for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2019
@GeniusLearner @miss-islington
bpo-21063: Improve module synopsis for distutils (pythonGH-17363)
32a5a69 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Nov 25, 2019
@bedevere-bot
Copy link

GH-17383 is a backport of this pull request to the 3.8 branch.

@brettcannon
Copy link
Member

@GeniusLearner thanks for the PR (and everyone else for the PR review)!

miss-islington added a commit that referenced this pull request Nov 25, 2019
@miss-islington @GeniusLearner
bpo-21063: Improve module synopsis for distutils (GH-17363)
089387e 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <[email protected]>
brettcannon pushed a commit that referenced this pull request Nov 26, 2019
@miss-islington @GeniusLearner @brettcannon
bpo-21063: Improve module synopsis for distutils (GH-17363) (#17381)
2f24893 
(cherry picked from commit f8a6316)

Co-authored-by: Sanchit Khurana <[email protected]>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@GeniusLearner
bpo-21063: Improve module synopsis for distutils (pythonGH-17363)
1913b11
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@GeniusLearner @shihai1991
bpo-21063: Improve module synopsis for distutils (pythonGH-17363)
9b3571a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@eamanu eamanu eamanu approved these changes

@CuriousLearner CuriousLearner CuriousLearner approved these changes

Assignees

@brettcannon brettcannon

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@GeniusLearner @bedevere-bot @CuriousLearner @miss-islington @brettcannon @eamanu @the-knights-who-say-ni