Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Bitbucket correctly #16862

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Spell Bitbucket correctly #16862

merged 1 commit into from
Oct 23, 2019

Conversation

bittner
Copy link
Contributor

@bittner bittner commented Oct 20, 2019

Automerge-Triggered-By: @Mariatta

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@bittner

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bittner
Copy link
Contributor Author

bittner commented Oct 20, 2019

I have now signed the contributor agreement and added my GitHub user name to my Python.org account.

Side note

Unfortunately, due to the slightly unclear login form, I accidentally created an additional account (username Peter Bittner). I didn't find a way to delete that account again, though. Can some admin delete that account on my behalf?

@bittner
Copy link
Contributor Author

bittner commented Oct 20, 2019

Related to this change, I have a question:

  • Is there a reason why the @pypa has repositories on GitHub and Bitbucket, but not on GitLab? (This paragraph in the docs is probably aged, and the characteristics of the main VCS's have changed over time.)

Should we mirror some of the PyPA's repositories to GitLab, at least? (I'm not sure where is the right place to ask this. Please, apologize if this question disturbs.)

@Mariatta
Copy link
Member

Thanks for the PR, once we have record that CLA has been signed, the PR will be automatically approved.

Re question about GitLab mirror for pypa, this is not the place to ask about it.
Perhaps try the pypa project: https://github.com/pypa

@bittner
Copy link
Contributor Author

bittner commented Oct 23, 2019

Have I done something wrong with the CLA? I even signed it twice, and it's still declared "not signed".

Is there some manual process involved? And we just need to be patient?

@Mariatta
Copy link
Member

@bittner the user https://bugs.python.org/user32717 in bpo does not have GitHub username associated, without it we can't tell if that user is linked to your GitHub.

Please add your GitHub username there, and then use this website to recheck https://check-python-cla.herokuapp.com/

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix also Doc/distributing/index.rst?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@serhiy-storchaka
Copy link
Member

I think such trivial change does not need signing the CLA.

@bittner
Copy link
Contributor Author

bittner commented Oct 23, 2019

@bittner the user https://bugs.python.org/user32717 in bpo does not have GitHub username associated, without it we can't tell if that user is linked to your GitHub.

Please add your GitHub username there, and then use this website to recheck https://check-python-cla.herokuapp.com/

That is the wrong account: I asked in #16862 (comment) if someone could delete it. It doesn't seem to be possible that one could do that themselves.

The correct user account is https://bugs.python.org/user15528, and that has the GitHub user name included. I've signed the CLA twice for this account. How can we find out what's broken here?

@bittner
Copy link
Contributor Author

bittner commented Oct 23, 2019

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka, @Mariatta: please review the changes made to this pull request.

@serhiy-storchaka
Copy link
Member

Thanks @bittner!

@serhiy-storchaka serhiy-storchaka merged commit d34ac30 into python:master Oct 23, 2019
@miss-islington
Copy link
Contributor

Thanks @bittner for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Oct 23, 2019
@bedevere-bot
Copy link

GH-16898 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-16899 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2019
(cherry picked from commit d34ac30)

Co-authored-by: Peter Bittner <[email protected]>
@bittner bittner deleted the patch-1 branch October 23, 2019 10:05
serhiy-storchaka pushed a commit that referenced this pull request Oct 23, 2019
(cherry picked from commit d34ac30)

Co-authored-by: Peter Bittner <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Oct 23, 2019
(cherry picked from commit d34ac30)

Co-authored-by: Peter Bittner <[email protected]>
@Mariatta
Copy link
Member

I don't have admin access to bpo, so I can't delete users.
You might just need to sign another CLA for the user https://bugs.python.org/user15528, or perhaps write to [email protected] to clarify the situation, and mentioned that the CLA should be received under the first account.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants