-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spell Bitbucket correctly #16862
Spell Bitbucket correctly #16862
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
I have now signed the contributor agreement and added my GitHub user name to my Python.org account. Side noteUnfortunately, due to the slightly unclear login form, I accidentally created an additional account (username Peter Bittner). I didn't find a way to delete that account again, though. Can some admin delete that account on my behalf? |
Related to this change, I have a question:
Should we mirror some of the PyPA's repositories to GitLab, at least? (I'm not sure where is the right place to ask this. Please, apologize if this question disturbs.) |
Thanks for the PR, once we have record that CLA has been signed, the PR will be automatically approved. Re question about GitLab mirror for pypa, this is not the place to ask about it. |
Have I done something wrong with the CLA? I even signed it twice, and it's still declared "not signed". Is there some manual process involved? And we just need to be patient? |
@bittner the user https://bugs.python.org/user32717 in bpo does not have GitHub username associated, without it we can't tell if that user is linked to your GitHub. Please add your GitHub username there, and then use this website to recheck https://check-python-cla.herokuapp.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix also Doc/distributing/index.rst?
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I think such trivial change does not need signing the CLA. |
That is the wrong account: I asked in #16862 (comment) if someone could delete it. It doesn't seem to be possible that one could do that themselves. The correct user account is https://bugs.python.org/user15528, and that has the GitHub user name included. I've signed the CLA twice for this account. How can we find out what's broken here? |
I have made the requested changes; please review again. |
Thanks for making the requested changes! @serhiy-storchaka, @Mariatta: please review the changes made to this pull request. |
Thanks @bittner! |
Thanks @bittner for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
GH-16898 is a backport of this pull request to the 3.8 branch. |
GH-16899 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit d34ac30) Co-authored-by: Peter Bittner <[email protected]>
(cherry picked from commit d34ac30) Co-authored-by: Peter Bittner <[email protected]>
(cherry picked from commit d34ac30) Co-authored-by: Peter Bittner <[email protected]>
I don't have admin access to bpo, so I can't delete users. |
Automerge-Triggered-By: @Mariatta