Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-17188: DOC: Document 'from None' in raise statement #1671

Merged
merged 3 commits into from
May 20, 2017
Merged

bpo-17188: DOC: Document 'from None' in raise statement #1671

merged 3 commits into from
May 20, 2017

Conversation

csabella
Copy link
Contributor

Prepare PR for patch by thomir to document 'from None' in raise statement.

@mention-bot
Copy link

@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @tiran and @rhettinger to be potential reviewers.

@terryjreedy terryjreedy requested a review from ncoghlan May 20, 2017 05:50
@terryjreedy
Copy link
Member

terryjreedy commented May 20, 2017 •
edited
Loading

The patch was written by Dennis Mårtensson (and Nick Coughlin in message) with edits by Nitika Agarwal and Thomi Richards. All have signed the CLA. Dennis should be credited as the 'original author' and added to Misc/ACKS.

@terryjreedy terryjreedy self-requested a review May 20, 2017 06:04
terryjreedy
terryjreedy approved these changes May 20, 2017
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the 1/0 message change, new example, and 3.3 notes (the last from Nick's message) and then rebuilt docs with patch. Web page looks good.

@codecov
Copy link

codecov bot commented May 20, 2017

Codecov Report

Merging #1671 into master will decrease coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
- Coverage   83.69%   82.67%   -1.02%     
==========================================
  Files        1371     1432      +61     
  Lines      346785   353138    +6353     
==========================================
+ Hits       290243   291968    +1725     
- Misses      56542    61170    +4628
Impacted Files Coverage Δ
Lib/test/test_select.py 87.69% <0%> (-1.54%) ⬇️
Lib/threading.py 82% <0%> (-0.87%) ⬇️
Lib/test/test_thread.py 66.66% <0%> (-0.52%) ⬇️
Lib/test/lock_tests.py 86.66% <0%> (-0.29%) ⬇️
Lib/test/test_strptime.py 94.76% <0%> (-0.27%) ⬇️
Lib/test/test_ftplib.py 95.98% <0%> (-0.26%) ⬇️
Lib/test/test_random.py 98.48% <0%> (-0.19%) ⬇️
Lib/test/test_buffer.py 96.53% <0%> (-0.18%) ⬇️
Tools/scripts/db2pickle.py 18% <0%> (ø)
Tools/scripts/which.py 16.66% <0%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3378b20...2b17e8d. Read the comment docs.

@terryjreedy
Copy link
Member

Nick, I requested review because my rst is rusty. But I decided to check by download and build. I think this is ready to merge when travis is done.

ncoghlan
ncoghlan approved these changes May 20, 2017
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Adding the label for a 3.6 backport so the default online docs get updated.

@terryjreedy terryjreedy merged commit 763557e into python:master May 20, 2017
@terryjreedy
Copy link
Member

Nick, I cannot do backports yet so I leave that to you.

@csabella csabella deleted the bpo17188 branch May 20, 2017 11:03
@Mariatta
Copy link
Member

@csabella Can you do the backport? Thanks :)
The commit hash is 763557e

csabella added a commit to csabella/cpython that referenced this pull request May 30, 2017
@csabella
[3.6] bpo-17188: DOC: Document 'from None' in raise statement (python…
34d5b84 
…GH-1671)

Original patch by Dennis Mårtensson.
(cherry picked from commit 763557e)
Mariatta pushed a commit that referenced this pull request May 30, 2017
@csabella @Mariatta
bpo-17188: DOC: Document 'from None' in raise statement (GH-1671) (GH…
00b381b 
…-1867)

Original patch by Dennis Mårtensson.
(cherry picked from commit 763557e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@csabella @mention-bot @terryjreedy @Mariatta @ncoghlan @the-knights-who-say-ni